Re: [long] worktree setup cases
- From
- Enrico Weigelt <weigelt@metux.de>
- Date
- Oct 21, 2010, 19:01 UTC
- Message-ID
- <20101021190146.GC28700@nibiru.local>
- In-Reply-To
- <7v8w1svate.fsf@alter.siamese.dyndns.org>
* Junio C Hamano <gitster@pobox.com> wrote:
> If you set GIT_DIR, we do no discovery, so git will work only from the > root level of the working tree (or bare repository operation) if you do > not tell us where the working tree is.
Well, we could look at config whether it's an non-bare repo and then lookup worktree via core.worktree (which would default to "../").
BTW: the whole discovery process IMHO should start w/ looking for the gitdir. Could be done this way:
a) explicitly given (via GIT_DIR or --git-dir), take this one. b) else: recursively scan for a valid .git dir from cwd upstairs to /
Once we've found gitdir, we can look for the worktree. Again:
a) explicitly given, then take it b) bare repo: dont have any, bail out c) non-bare repo: look up via core.worktree (w/ default to $GIT_DIR/../)
> Shouldn't all of these 16 be the same, if the repository is bare? What is > your definition of bareness? core.bare? In any case we should say "you > are using a bare repository, there is no working tree" and cwd shouldn't > change in these cases. They are all bare and there is no working tree.
ACK. In a bare repo, the worktree lookup will fail per definition, so worktree operations can only run with having it explicitly given.
cu
-- ---------------------------------------------------------------------- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weigelt@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 ---------------------------------------------------------------------- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme ----------------------------------------------------------------------