Re: [PATCH] t0003: properly quote $HOME

From: Thomas Rast <trast@student.ethz.ch>
Date: Oct 17, 2010, 19:34 UTC
Message-ID: <201010172134.43983.trast@student.ethz.ch>
In-Reply-To: <20101017191827.GD3202@burratino>

Jonathan Nieder wrote:

Show 11 quoted lines

> Thomas Rast wrote:
> 
> > 6df42ab (Add global and system-wide gitattributes, 2010-09-01) forgot
> > to quote one instance of $HOME in the tests.  This broke the test for
> > me with the shell complaining about an ambiguous redirect (but only
> > when run with --root for some reason).
> 
> Thanks.  What shell do you use?
> 
> IIRC it is not ambiguous according to POSIX but since e.g. OpenBSD
> complains it is worth fixing.

Oh, huh, so much for the theory that it's --root causing it:

  $ sh ./t0003-attributes.sh -q
  # passed all 8 test(s)
  1..8
  $ dash ./t0003-attributes.sh -q
  # passed all 8 test(s)
  1..8
  $ bash ./t0003-attributes.sh -q
  not ok - 1 setup
[...]
  $ bash --version
  GNU bash, version 4.1.7(1)-release (x86_64-suse-linux-gnu)
[...]

Then again, so much for your theory that it's only OpenBSD... ;-)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch