Re: [RFC PATCH] Makefile: new prove target for running the tests with TAP

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 14, 2010, 16:27 UTC
Message-ID: <20101014162757.GC16500@burratino>
In-Reply-To: <5c46df95f93b56aa2fce56c7efe7b2be80642c8b.1287045908.git.git@drmicha.warpmail.net>

Michael J Gruber wrote:

> Introduce a new make target "prove" which runs the tests via "prove"

I like it. :)

I've been using

	prove -j2 --shuffle t[0-9]*.sh

and would be happier to be able to dump GIT_PROVE_OPTS="-j2 --shuffle" in my config.mak and just run "make prove" instead of that unwieldly glob.

Show 12 quoted lines

> RFC also because of lack of doc, and:
> 
> Currently, one can do
> 
> make -C t t6010-merge-base.sh
> 
> or even
> 
> make -C t t601*
> 
> which is cool but undocumented. If we want this with prove it requires more
> effort

Doesn't "prove t601*" work well for that use case already?

> --- a/t/Makefile
> +++ b/t/Makefile

[...]

Show 6 quoted lines

> +prove: pre-clean
> +	@echo "*** prove ***"; GIT_CONFIG=.git/config $(PROVE) --exec '$(SHELL_PATH_SQ)' $(GIT_PROVE_OPTS) $(T) :: $(GIT_TEST_OPTS)
> +	$(MAKE) clean
> +
>  $(T):
>  	@echo "*** $@ ***"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)

Not about this patch, but is that GIT_CONFIG setting needed? I would have guessed rather that test-lib.sh would unset GIT_CONFIG as soon as possible.