Re: [PATCH] rev-list: handle %x00 NUL in user format

> Jeff King <peff@peff.net> writes:
> 
> > Erik mentioned a potential problem with fwrite() and the way we handle
> > ANSI emulation for Windows. I think if there is a problem, then the same
> > problem exists in the --graph code, and we should do this, and then fix
> > both on top.
> 
> I am quite sure that --graph codepath is used a lot less often than this
> codepath, and most users do not hit the problem you are fixing---that is
> why it took so long to get noticed.  I think this printf() has been there
> from the beginning, even though the possibility of placing a NUL in
> buf.buf may have come much later, like when %x00 was introduced).
> 
> Use of fwrite() here will affect all Windows users who use color (probably
> most of them), no?  It may be a deliberate regression, but it has a real
> cost associated with it; it will break more usual uses on Windows to help
> an obscure use case on POSIX.