Re: [PATCH v5 3/4] [RFC] Only show bulkmoves in output.
- From
- Yann Dirson <ydirson@free.fr>
- Date
- Oct 10, 2010, 12:39 UTC
- Message-ID
- <20101010123954.GB4983@home.lan>
- In-Reply-To
- <1286659895-1813-4-git-send-email-ydirson@altern.org>
On Sat, Oct 09, 2010 at 11:31:34PM +0200, Yann Dirson wrote:
Show 8 quoted lines
> In theory we could just append those at display time (possibly diluting
> the code too much ?), or before queing the diff. In practice we cannot
> do the latter easily in either case (strcat to a constant string ("./"),
> nor to the paths tighly-allocated from alloc_filespec).
>
> So I went the way of including the trailing "*" from the beginning.
> Since I'm still unsure whether keeping it that way, I leave it as a
> separated patch for now.Thinking twice, that approach has a major problem: it will break when a file is named "*". Finally looks like differing this to display time will be the most sensible solution.