Re: [PATCH 2/6] Fix odd markup in --diff-filter documentation

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 8, 2010, 18:03 UTC
Message-ID: <20101008180327.GA13910@burratino>
In-Reply-To: <87bp74tvno.fsf@gmail.com>

Štěpán Němec wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:

Show 5 quoted lines

>> Strictly speaking, --diff-filter= (with empty argument) is allowed, too,
>> but I don't know if it's worth fitting that in.
>
> If it provides some kind of useful behaviour (I don't know and you
> didn't clarify that either), then it should be documented I guess?

Just a special case of the usual behavior: it selects the empty set of files. Doesn't sound useful to me, but maybe someone writing a front-end would want to be reassured that --diff-filter will still work if the user unchecks all the boxes.

Of course, one can also just try it...

If you can find a way to format it nicely (using brackets?), then I think it should be part of the documented syntax, yes.