Re: git diff --check always shows line 1 for blank at EOF for new files

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 7, 2010, 09:32 UTC
Message-ID: <20101007093258.GA10941@burratino>
In-Reply-To: <4CAC411E.3010204@gmx.de>

Hi Christoph,

Christoph Mallon wrote:

Show 17 quoted lines

>   git init test
>   cd test
>   printf 'a\nb\nc\n\n' > file
>   git add -AN
>   git diff --check
> 
> The last command will show "file:1: new blank line at EOF.".
> 
> It works fine, if the diff is not against /dev/null, e.g.:
>   git init test
>   cd test
>   printf 'a\nb\nc\n' > file
>   git add -A
>   echo >> file
>   git diff --check
> 
> This correctly shows "file:4: new blank line at EOF.".

Try this:

    git init test
    cd test
    printf 'a\nb\nc\n' > file
    git add -A
    echo hello >> file
    echo >> file
    git diff --check

As you can see, it still returns line 4, which is the beginning of the hunk that adds the blank line.

A change to make it print the line number of the blank line itself does not sound so bad, though.