Re: [PATCH v4 2/3] git-remote-fd
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 4, 2010, 11:25 UTC
- Message-ID
- <20101004112556.GD4738@burratino>
- In-Reply-To
- <1286190258-12724-3-git-send-email-ilari.liusvaara@elisanet.fi>
Ilari Liusvaara wrote:
> --- /dev/null > +++ b/Documentation/git-remote-fd.txt
Much clearer. The synopsis still does not make me happy; the synopsis I suggested did not make me happy, either. Some section headers still have trailing colons but I'm not convinced that's worth the overhead to fix.
> --- /dev/null > +++ b/builtin/remote-fd.c
Looks good. Probably input_fd and output_fd should be static --- Junio, can you fix that up? And now that the documentation makes it clear this is only for fetch, push, and archive, I guess I am not so worried about the interface any more.