git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Move call to evaluate_git_version after evaluate_gitweb_config

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 26, 2010, 11:34 UTC
Message-ID
<20100926113431.28918.53550.stgit@localhost.localdomain>

This means that call to evaluate_git_version() is now inside run_request(), which means that is called for each request instead of once per starting gitweb; this matter currently only when using FastCGI interface (gitweb.fcgi).

This change was done becayse evaluate_git_version() uses $GIT variable, which can be set / modified by gitweb config file... and it is modified this way by gitweb config file used in gitweb tests. Without this change there is spurious extra output from t9500 test when tests are run with '--debug' option.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index a85e2f6..d521b4c 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1061,6 +1061,7 @@ sub run_request {
 
 	evaluate_uri();
 	evaluate_gitweb_config();
+	evaluate_git_version();
 	check_loadavg();
 
 	# $projectroot and $projects_list might be set in gitweb config file
@@ -1113,7 +1114,6 @@ sub evaluate_argv {
 
 sub run {
 	evaluate_argv();
-	evaluate_git_version();
 
 	$pre_listen_hook->()
 		if $pre_listen_hook;
Message 1 of 1 in “gitweb: Move call to evaluate_git_version after evaluate_gitweb_config”
  1. gitweb: Move call to evaluate_git_version after evaluate_gitweb_configJakub Narebski, Sep 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.