Re: [PATCH/RFC 3/3] t/gitweb-lib.sh: Add support for GITWEB_TEST_INSTALLED

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 12, 2010, 19:33 UTC
Message-ID: <201009122133.26427.jnareb@gmail.com>
In-Reply-To: <7vtylueuc4.fsf@alter.siamese.dyndns.org>

On Sun, 12 Sep 2010, Junio C Hamano wrote:

Show 8 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > It is an RFC because I am not sure where to put documentation,
> > i.e. description of GITWEB_TEST_INSTALLED.  Should it be put in
> > t/README, in gitweb/README, or in gitweb/INSTALL, or in
> > t/gitweb-lib.sh header?
> 
> I think the comment in this file is fine.

O.K.

Show 12 quoted lines

> > +	# You can set the GITWEB_TEST_INSTALLED environment variable to
> > +	# the gitwebdir (the directory where gitweb is installed / deployed to)
> > +	# of an existing gitweb instalation to test that installation.
> > +	if test -n "$GITWEB_TEST_INSTALLED" ; then
> > +		SCRIPT_NAME="$GITWEB_TEST_INSTALLED/gitweb.cgi"
> > +		test -f "$SCRIPT_NAME" ||
> > +		error "Cannot find gitweb.cgi at $GITWEB_TEST_INSTALLED."
> 
> I don't know if GIT_WEB_TEST_INSTALLED=/path/to/some/directory (naming the
> directory that houses the script which must be named gitweb.cgi) is easier
> to use than GIT_WEB_TEST_INSTALLED=/path/to/some/gitweb.perl (naming the
> script that is allowed to be renamed).

First, I was following what GIT_TEST_INSTALLED does (it points to bindir, not to git binary). Second, I had half of idea to also change paths to static files... but they are not used anyway, at least not currently (no check for links).

Anyway we can support both situations, slightly similarly to how GIT_TRACE can have different kinds of values.

-- 
Jakub Narebski
Poland