Re: [RFC PATCH] git-help: find library man pages again

From: Jeff King <peff@peff.net>
Date: Sep 9, 2010, 19:58 UTC
Message-ID: <20100909195808.GD1146@sigill.intra.peff.net>
In-Reply-To: <4C7F6354.70108@drmicha.warpmail.net>

On Thu, Sep 02, 2010 at 10:41:56AM +0200, Michael J Gruber wrote:

Show 9 quoted lines

> >  i.e. I think that is the same issue after all and that
> > builtin/help.c ought to learn another heuristic than is_git_command().
> 
> One heuristic, which I would have left for a later patch because of its
> radicality (and I think we're in some phase of some rc something), is to
> simply not do any checks when calling the viewers. This requires that
> everything is prepended with "git-", which I see you have done in
> builtin/help.c. Still, none-command help pages will not show up with
> "git help -a". So it's not a complete solution.

That was my first thought upon reading your patch, too. And something like "s/gitworkflows/git-workflows/" is reasonable. But you can do "git help attributes" and "git help ignore" now, and those should almost certainly remain "gitattributes" and "gitignore" (at the very least, we should still allow "git help gitattributes", which works now, but which your proposal would break).

So maybe we could get by with "prepend git- unless it starts with git".

I dunno. The current behavior seems hack-ish, but I am loathe to change names if people really prefer the existing ones. FWIW, I would actually say "git help git-sh-setup", which in fact works (leading me to get puzzled by your patch at first). So who knows what people are typing in practice.

-Peff