git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] gitweb: skip logo in atom feed when there is none

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Sep 2, 2010, 23:55 UTC
Message-ID
<20100902235546.GC6466@burratino>
In-Reply-To
<20100902235237.GA6466@burratino>

With v1.5.0-rc0~169 (gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url, 2006-12-04), the logo URI to be written to Atom feeds was corrected but the case of no logo forgotten.

Cc: Jakub Narebski <jnareb@gmail.com>
Cc: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Theoretical, untested.
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index a97ce03..cc20e74 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -6630,7 +6630,7 @@ XML
 		if (defined $favicon) {
 			print "<icon>" . esc_url($favicon) . "</icon>\n";
 		}
-		if (defined $logo_url) {
+		if (defined $logo) {
 			# not twice as wide as tall: 72 x 27 pixels
 			print "<logo>" . esc_url($logo) . "</logo>\n";
 		}
-- 
1.7.2.2
Previous: Jonathan NiederNext: Jonathan Nieder
Message 10 of 14 in “git instaweb for Debian squeeze (Re: Bug#592733: git instaweb broken)”
  1. Jonathan NiederSep 2, 2010
  2. Eric WongSep 2, 2010
  3. 0/4 instaweb 1.7.1 fixes for Debian squeezeJonathan Nieder, Sep 2, 2010
  4. 1/4 instaweb: ignore GITWEB_CONFIG_SYSTEMJonathan Nieder, Sep 2, 2010
  5. Junio C HamanoSep 3, 2010
  6. Jonathan NiederSep 3, 2010
  7. Jonathan NiederSep 3, 2010
  8. Junio C HamanoSep 4, 2010
  9. Jonathan NiederSep 4, 2010
  10. 2/4 gitweb: skip logo in atom feed when there is noneJonathan Nieder, Sep 2, 2010
  11. 3/4 gitweb: make logo optionalJonathan Nieder, Sep 2, 2010
  12. 4/4 instaweb: disable logo and favicon by defaultJonathan Nieder, Sep 2, 2010
  13. 4/4 instaweb: disable logo and favicon by defaultJonathan Nieder, Sep 3, 2010
  14. Eric WongSep 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.