Re: [PATCH 2/1] do not pass "git -c foo=bar" params to transport helpers

From: Jeff King <peff@peff.net>
Date: Aug 24, 2010, 14:14 UTC
Message-ID: <20100824141416.GC6457@coredump.intra.peff.net>
In-Reply-To: <20100824064114.GA20724@burratino>

On Tue, Aug 24, 2010 at 01:41:14AM -0500, Jonathan Nieder wrote:

> Like $GIT_CONFIG, $GIT_CONFIG_PARAMETERS needs to be suppressed by
> "git push" and its cousins when running local transport helpers to
> imitate remote transport well.

Thanks, this looks good to me.

Though arguably these bits:

> +#define CONFIG_DATA_ENVIRONMENT "GIT_CONFIG_PARAMETERS"
> [...]
> -	const char *old = getenv("GIT_CONFIG_PARAMETERS");
> +	const char *old = getenv(CONFIG_DATA_ENVIRONMENT);

Should be squashed into the original patch. :)

-Peff