Re: [PATCH v3] shell: Rewrite documentation and improve error message

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Aug 24, 2010, 12:35 UTC
Message-ID: <20100824123525.GA18641@kytes>
In-Reply-To: <AANLkTikeZTF5zZyRDtLfnPrtCYFH0WayXrJeCj8_VuC1@mail.gmail.com>

Hi Greg,

Greg Brockman writes:

> >  -                          "hint: ~/$COMMAND_DIR should exist "
> >  +                          "hint: ~/" $COMMAND_DIR " should exist "
> There's still a floating $.  (Recall, you're in C land here, not shell.)

Ugh. So sorry about this- I've been suffering from insomnia over the last few days.

-- 8< --

diff --git a/shell.c b/shell.c
index 6aade3d..b539cdf 100644
--- a/shell.c
+++ b/shell.c
@@ -154,7 +154,7 @@ int main(int argc, char **argv)
 		cd_to_homedir();
 		if (access(COMMAND_DIR, R_OK | X_OK) == -1) {
 			die("Interactive git shell is not enabled.\n"
-			    "hint: ~/" $COMMAND_DIR " should exist "
+			    "hint: ~/" COMMAND_DIR " should exist "
 			    "and have read and execute access.");
 		}
 		run_shell();