Re: [PATCH] reset: Better warning message on git reset --mixed <paths>
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Aug 15, 2010, 19:49 UTC
- Message-ID
- <20100815194913.GB1856@burratino>
- In-Reply-To
- <7vr5hzg1u1.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> If you want to reset the index at selected paths, don't use any option, as > nothing but --mixed makes sense. Hence we deprecated use of --mixed when > used this way. But if _it_ makes sense, why deprecate it? What harm > would it do if we took it silently?
Nothing major. It would be the same inconsistency as we currently have between "checkout <commit> -- <pathspec>" and "checkout <commit> --": one updates the HEAD (or rather, for "reset", the current branch), while the other doesn’t.
So my preference is to make "reset --foo" not take a pathspec, but it is not a strong one.