Re: [PATCH] Do not build i18n on Windows.

From: Johannes Sixt <j6t@kdbg.org>
Date: Aug 14, 2010, 08:24 UTC
Message-ID: <201008141024.42093.j6t@kdbg.org>
In-Reply-To: <AANLkTiku5R+idX-C8f0AcCikBLmfEb5ZEhdft+CSRzU0@mail.gmail.com>

On Samstag, 14. August 2010, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> On Fri, Aug 13, 2010 at 22:02, Johannes Sixt <j6t@kdbg.org> wrote:
> > We do not have the necessary libraries and tools.
>
> Just curious, do you mean Windows / MINGW can't build gettext, or that
> you just haven't done so in your build process yet? At least
> http://www.mingw.org/wiki/LibrariesAndTools seems to indicate that
> libintl has been ported to Windows.

The msysgit build environment that I am using does not have libintl. The reason *might* be that I haven't updated it since months. Upstream msysgit could already have it.

The MSVC build environment doesn't have libintl in any case. Even if msysgit gains libintl, the MSVC does *not* automatically gain it as well. Hence, setting NO_GETTEXT in the MSVC section of the Makefile makes sense for now.

BTW, libintl is not the only obstacle: the gettext tools are needed as well.

> If you're just not interested in building gettext by default on
> Windows I think it's completely reasonable to add it to the Makefile
> (given that you're probably pretty much the only one doing so). It
> would just be useful to clarify the "why".

As long as libintl and the gettext tools are not in msysgit, we should set NO_GETTEXT for MinGW builds. Once we have them, I don't care that much whether we set it by default or not.

-- Hannes