git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] More readable 'Not a git repository' messages

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 9, 2010, 23:01 UTC
Message-ID
<20100809230132.GG4429@burratino>
In-Reply-To
<i3q0d8$m8f$1@dough.gmane.org>
Ralf Ebert wrote:
> this code is inside a loop that goes up in the directory hierarchy.
> So cwd[offset] = '\0' does not only happen once before dying.

I hope not, since then the returned cwd value would be useless for restoring the original cwd later.

Shameless plug: you may find the version in commit 98937be (i.e. branch jn/maint-setup-fix in pu) more readable. :)

Previous: Ralf EbertNext: Ralf Ebert
Message 4 of 13 in “More readable 'Not a git repository' messages”
  1. More readable 'Not a git repository' messagesRalf Ebert, Aug 9, 2010
  2. Nguyen Thai Ngoc DuyAug 9, 2010
  3. Ralf EbertAug 9, 2010
  4. Jonathan NiederAug 9, 2010
  5. Ralf EbertAug 9, 2010
  6. Nguyen Thai Ngoc DuyAug 10, 2010
  7. Sverre RabbelierAug 10, 2010
  8. Jared HanceAug 10, 2010
  9. Joshua JuranAug 10, 2010
  10. More readable 'Not a git repository' messagesRalf Ebert, Aug 13, 2010
  11. Joshua JuranAug 13, 2010
  12. setup.c: Improve 'Not a git repository' messagesRalf Ebert, Aug 15, 2010
  13. Jonathan NiederAug 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.