Re: [PATCH] tests: A new test prereq for testing chmod -w as root

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 4, 2010, 20:40 UTC
Message-ID: <20100804204015.GA2920@burratino>
In-Reply-To: <7veieefaym.fsf@alter.siamese.dyndns.org>

Hi Ævar,

Junio C Hamano wrote:

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 6 quoted lines

>> Some tests depend on not being able to read files after chmod -w. This
>> doesn't work when running the tests as root.
>
> Obviously you meant s/read/write/ or "chmod -r" ;-)
> 
> We discussed this prerequisite in the past as "SANITY"

[...]

> Also I think there was a discussion and proposed patch to support more
> than one prerequisite tokens, concatenated with "," or something

Thanks for picking up this topic.  Here’s some related work:

 - Incomplete series using space-separated test prerequisites:
   http://thread.gmane.org/gmane.comp.version-control.git/145427

 - Why that series is incomplete:
   http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=104;bug=579273

 - Comma-separated test prerequisites:
   http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118434

 - Earlier.
   http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118385

>     test_expect_success POSIXPERM,SANITY

Last time I looked, IFS=, as used by Hannes looked like a sane approach. I noticed too late and did not follow up; sorry about that.