git/list[1] front-page[2] threads[3] people[4] search[5] about
 

gitweb not friendly to firefox revived

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Aug 1, 2010, 19:51 UTC
Message-ID
<20100801195138.GA1980@pengutronix.de>
Hello,
gitweb (at least) doesn't quote author names enough.
Firefox barfs for me at looking at
	http://git.pengutronix.de/?p=ukl/linux-2.6.git;a=shortlog;h=v2.6.16.10
with an error:
	XML Parsing Error: not well-formed Location:
http://git.pengutronix.de/?p=ukl/linux-2.6.git;a=shortlog;h=v2.6.16.10
Line Number 112, Column 81:
<td class="author"><a title="Search for commits authored by YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" class="list" href="/?p=ukl/linux-2.6.git;a=search;h=v2.6.16.10;s=YOSHIFUJI+Hideaki+/+%1B%24B5HF%231QL@%1B(B;st=author"><span title="YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B">YOSHIFUJI Hideaki...  </span></a></td><td><a class="list subject" title="[PATCH] IPV6: XFRM: Fix decoding session with preceding extension header(s)." href="/?p=ukl/linux-2.6.git;a=commit;h=fa39df2ff7f6102f1f37d3cf1f68243534d56253">[PATCH] IPV6: XFRM: Fix decoding session with preceding... </a></td>
--------------------------------------------------------------------------------^
This is with git 1.7.1 and Iceweasel (aka. Firefox) 3.5.10.
Making
	title=>"Search for commits $performed by $author"

in line 1694 of Debian's /usr/lib/cgi-bin/gitweb.cgi from the git 1.7.1 package read

	title=>esc_html("Search for commits $performed by $author")
this problem goes away.  (Still my browser barfs when clicking at the name.)

I'm not sure if this is the right way to fix this and I'm too tired now to do a complete patch, so I let this for someone else.

Best regards Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Next: Ævar Arnfjörð Bjarmason
Message 1 of 12 in “gitweb not friendly to firefox revived”
  1. Uwe Kleine-KönigAug 1, 2010
  2. Ævar Arnfjörð BjarmasonAug 1, 2010
  3. Uwe Kleine-KönigAug 2, 2010
  4. Jakub NarebskiAug 1, 2010
  5. Uwe Kleine-KönigAug 3, 2010
  6. Jakub NarebskiAug 3, 2010
  7. Uwe Kleine-KönigAug 12, 2010
  8. Stephen BoydAug 14, 2010
  9. Ævar Arnfjörð BjarmasonAug 14, 2010
  10. Jakub NarebskiAug 14, 2010
  11. Uwe Kleine-KönigSep 7, 2010
  12. Jakub NarebskiAug 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.