jk/tag-contains (Re: What's cooking in git.git (Jul 2010, #05; Wed, 28))

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 31, 2010, 06:07 UTC
Message-ID: <20100731060703.GA21207@burratino>
In-Reply-To: <20100730183709.GC18544@coredump.intra.peff.net>

Jeff King wrote:

> What do we want to do with this?

Probably I have already said too much about this topic, but here I go:

> The third one is where we start defaulting things to "assume no more
> than 1 day of clock skew by default", which can cause incorrect answers
> in the face of skew.

I think the default should be something that (just barely) works correctly for linux-2.6.git.

> The fourth is just an illustrative patch for per-repo skew detection.

I have been hoping for a chance to look these over, time hasn’t come my way yet.

>                                                          I can work up a
> "detect clock skew on clone and gc" patch based on it if we want to go
> that way.

That sounds very sane.

Additional things to do (this is mostly a note to myself):

 - refuse to commit with a timestamp long before any parent

 - refuse to make a commit that would make the total slop too high?

 - check slop and warn about it in fsck (maybe your patch does this
   already)

 - document the maximum-total-slop and maximum-single-commit-slop
   rules!