Re: [msysGit] git rev-parse broken on Git for Windows

From: Thomas Rast <trast@student.ethz.ch>
Date: Jul 30, 2010, 09:02 UTC
Message-ID: <201007301102.15274.trast@student.ethz.ch>
In-Reply-To: <alpine.DEB.1.00.1007301022310.2983@bonsai2>

Johannes Schindelin wrote:

Show 13 quoted lines

> Hi,
> 
> On Thu, 29 Jul 2010, Joshua Jensen wrote:
> 
> >  9c7304e3e39ed397b3cc6566573333e2698a52b4 (print the usage string on stdout
> > instead of stderr) and then 47e9cd28f8a404a0d6293935252ddca5fc243931
> > (parseopt: wrap rev-parse --parseopt usage for eval consumption) break the
> > following line from the manual and 'git subtree' on msysGit:
> > 
> > eval $(echo "$OPTS_SPEC" | git rev-parse --parseopt -- "$@" || echo exit $?)
> 
> Both commits are from Junio's 'next' branch. I Cc:ed the authors of both 
> commits.

Can you elaborate on "break"?

Because as you can see in git-sh-setup.sh, the "official" user of parseopt does

	eval "$(
		echo "$OPTIONS_SPEC" |
			git rev-parse --parseopt $parseopt_extra -- "$@" ||
		echo exit $?
	)"

So AFAICS they only differ in the quoting.  And the latter works.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch