git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git svn: add an option to recode pathnames

From
EWEric Wong <normalperson@yhbt.net>
Date
Jul 30, 2010, 07:59 UTC
Message-ID
<20100730075921.GA9596@dcvr.yhbt.net>
In-Reply-To
<4C523935.5070504@gmail.com>
Robert Pollak <robert.pollak@gmail.com> wrote:
Show 15 quoted lines
> Introduce a new option 'svn.pathnameencoding' that instructs git svn to
> recode pathnames to a given encoding.  It can be used by windows users
> and by those who work in non-utf8 locales to avoid corrupted file names
> with non-ascii characters.
> 
> Signed-off-by: Dmitry Statyvka <dstatyvka@tmsoft-ltd.kiev.ua>
> [robert.pollak@gmail.com: renamed the option and added manpage documentation]
> Signed-off-by: Robert Pollak <robert.pollak@gmail.com>
> ---
> 
> Hello Eric,
> 
> since the patch is useful to me, I have made the requested option name
> change and added some manpage documentation. Please consider applying the
> patch or give me additional feedback.
Thanks Robert!

It looks alright to me and I've acked and pushed it out to git://git.bogomips.org/git-svn (crediting Dmitry as the author)

If it's not too much trouble, having a test case to ensure it stays working with future changes would be nice.

> This is the first patch I submit on this list, so I hope it's ok.

For addendum changes, the standard we seem to have adopted is first initials above the Signed-off/Acked-by lines:

>From 3713e2226bcda64513efd537f370ce4d7f767a1e Mon Sep 17 00:00:00 2001
From: Dmitry Statyvka <dstatyvka@tmsoft-ltd.kiev.ua>
Date: Fri, 30 Jul 2010 04:30:13 +0200
Subject: [PATCH] git svn: add an option to recode pathnames

Introduce a new option 'svn.pathnameencoding' that instructs git svn to recode pathnames to a given encoding. It can be used by windows users and by those who work in non-utf8 locales to avoid corrupted file names with non-ascii characters.

[rp: renamed the option and added manpage documentation]
Signed-off-by: Dmitry Statyvka <dstatyvka@tmsoft-ltd.kiev.ua>
Signed-off-by: Robert Pollak <robert.pollak@gmail.com>
Acked-by: Eric Wong <normalperson@yhbt.net>
---
<snip>
-- 
Eric Wong
Previous: Robert PollakNext: Dmitry Statyvka
Message 4 of 5 in “git svn: add an option to recode pathnames”
  1. git svn: add an option to recode pathnamesDmitry Statyvka, Jul 29, 2009
  2. Eric WongJul 29, 2009
  3. Robert PollakJul 30, 2010
  4. Eric WongJul 30, 2010
  5. Dmitry StatyvkaAug 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.