Re: [RFC PATCH 0/2] Allow detached forms (--option arg) for git log options.
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jul 26, 2010, 19:31 UTC
- Message-ID
- <20100726193109.GA1043@burratino>
- In-Reply-To
- <1280168078-31147-1-git-send-email-Matthieu.Moy@imag.fr>
Hi Matthieu,
Matthieu Moy wrote:
> is there any reason why "git log" hasn't been > migrated to parse-option? Or is it only that nobody did it yet?
Please go ahead. :)
The difficult piece is that the diff and revision handling options are shared by a large number of commands.
I think my favorite idea is to provide macros to include the appropriate entries in option tables[1]. Plus side: very easy for callers to use. Downside: bloats the option tables, though I think that can be worked around.
Junio seemed to suggest that adapting the current multi-pass procedure might be easier[2].
That said, in the meantime, something like this series (just for -S it would be a big improvement already) would make sense to me.
Thanks. Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/85354/focus=85391 [2] http://thread.gmane.org/gmane.comp.version-control.git/85354/focus=85362