Patch follow-up conventions (Re: [PATCH] Makefile: don't include git version file on 'make clean')

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 25, 2010, 18:49 UTC
Message-ID: <20100725184951.GA9636@burratino>
In-Reply-To: <1279943627-11053-1-git-send-email-Lynn.Lin@emc.com>

Hi Lynn,

Lynn Lin wrote:

Show 5 quoted lines

> -----Original Message-----
> From: Jonathan Nieder [mailto:jrnieder@gmail.com] 
> Sent: 2010年7月24日 19:52
> To: Lin, Lynn
> Subject: Re: [PATCH] Makefile: don't include git version file on 'make clean'

[...]

> Thanks much ,Jonathan.
> It's my first time to try submit patch to git project:)
> 
> Do I need to re-submit patch to add more message in commit message ?

No problem; it is always good to see people noticing things that can be improved and fixing them. :)

In general the best thing to do (though hard) is to imagine what would be most convenient at the receiving end and support that. This means:

 - do not resend a whole patch when a small fixup would be easier;

 - if there has been a long discussion, once a patch is ready
   send a copy with [PATCH v2] in the subject, with a summary
   of the discussion after the "---" line and cc-ing Junio to let
   him know it is ready for application.

Another piece of advice: please convince your mailer setup to present replies in a more useful form. That means snipping out any irrelevant text and somehow visually distinguishing the text you are quoting from your reply, like I have done with "> " above.

Hope that helps, Jonathan