Re: [PATCH 1/2] log-tree: simplify digit_in_number

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 25, 2010, 17:46 UTC
Message-ID: <20100725174602.GA9146@burratino>
In-Reply-To: <1280079381-4548-1-git-send-email-ralf.thielow@googlemail.com>

Ralf Thielow wrote:

Show 15 quoted lines

> +++ b/log-tree.c
> @@ -254,12 +254,10 @@ static void append_signoff(struct strbuf *sb, const char *signoff)
>  
>  static unsigned int digits_in_number(unsigned int number)
>  {
> -	unsigned int i = 10, result = 1;
> -	while (i <= number) {
> -		i *= 10;
> -		result++;
> -	}
> -	return result;
> +	int digits = 0;
> +	while (number /= 10) 
> +		digits++;
> +	return digits++;

I think you mean "return ++digits;".

But other questions come to mind first:

 - What is the motivation?  How did this come up and what does your change
   improve?

 - Why rewrite this in one patch, only to rewrite it again?

Hope that helps, Jonathan