Re: [PATCH] git-svn: write memoized data explicitly to avoid Storable bug

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 19, 2010, 06:39 UTC
Message-ID: <20100719063903.GA3680@dcvr.yhbt.net>
In-Reply-To: <1279455469-6384-1-git-send-email-vsu@altlinux.ru>

Sergey Vlasov <vsu@altlinux.ru> wrote:

Show 13 quoted lines

> Apparently using the Storable module during global destruction is
> unsafe - there is a bug which can cause segmentation faults:
> 
>   http://rt.cpan.org/Public/Bug/Display.html?id=36087
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482355
> 
> The persistent memoization support introduced in commit 8bff7c538
> relied on global destruction to write cached data, which was leading
> to segfaults in some Perl configurations.  Calling Memoize::unmemoize
> in the END block forces the cache writeout to be performed earlier,
> thus avoiding the bug.
> 
> Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>

Thanks Sergey,

Acked-by: Eric Wong <normalperson@yhbt.net>

...and pushed to git://git.bogomips.org/git-svn

-- 
Eric Wong