Re: [PATCH/RFC 4/4] Add interactive mode to git-shell for user-friendliness

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 17, 2010, 05:52 UTC
Message-ID: <20100717055257.GB29290@burratino>
In-Reply-To: <AANLkTikiOgV1iE7dwPUkLpWTb_zXSFdEuOYvyqJ1eDCo@mail.gmail.com>

Hi Greg,

Greg Brockman wrote:

> - Extend run_command to optionally use execv.  Would any other code
> actually want this functionality though?  If not, it's probably an
> excessively large code change for little benefit.

Of the options you presented, this is the best one. It doesn’t matter whether any other code would use it; even if you are the only caller, it is still good because

 - if someone else needs the facility, it will be obvious where
   to find it

 - you can share the existing logic to portably run a command
   (i.e., near free portability to msys).

run_command() already takes an argument for options like RUN_USING_SHELL; your new facility would fit right in.

But first a more basic question: why not just add “./” to the start of the command name?