Re: [PATCH 1/2] revert: refactor code that prints success or failure message

From: Christian Couder <chriscool@tuxfamily.org>
Date: Jul 15, 2010, 09:26 UTC
Message-ID: <201007151126.57840.chriscool@tuxfamily.org>
In-Reply-To: <20100713221620.GA4763@burratino>

Hi,

On Wednesday 14 July 2010 00:16:20 Jonathan Nieder wrote:

Show 26 quoted lines

> Christian Couder wrote:
> > I don't know about sh -x but there is this code in test-lib.sh to warn
> > about GIT_TRACE use:
> > 
> > case $(echo $GIT_TRACE |tr "[A-Z]" "[a-z]") in
> > 
> > 	1|2|true)
> > 	
> > 		echo "* warning: Some tests will not work if GIT_TRACE" \
> > 		
> > 			"is set as to trace on STDERR ! *"
> > 		
> > 		echo "* warning: Please set GIT_TRACE to something" \
> > 		
> > 			"other than 1, 2 or true ! *"
> > 		
> > 		;;
> > 
> > esac
> 
> Oh!  I just remembered
> 
>   http://thread.gmane.org/gmane.comp.version-control.git/146767
> 
> I guess the answer is we half-support it.  Maybe a test_cmp_err()
> helper to strip out xtrace[1] and GIT_TRACE[2] output is needed.

I don't understand the result of the above thread but when I try "bash -x t3508-cherry-pick-many-commits.sh" it works on my machine. So I didn't change the tests.

Show 7 quoted lines

> >> Summary: I was misled by the commit message.
> 
> [...]
> 
> > Ok, I will improve it.
> 
> Thanks, and sorry for the unfocused review.

No problem it's still better than no review :-)

Thanks, Christian.