Re: [PATCH] fast-import: export correctly marks larger than 2^20-1

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 13, 2010, 18:31 UTC
Message-ID: <20100713183126.GA2458@burratino>
In-Reply-To: <1279021908-21291-1-git-send-email-harinath@hurrynot.org>

(+cc David, who I think mentioned wishing for something like this)

Raja R Harinath wrote:

> Subject: fast-import: export correctly marks larger than 2^20-1

Thank you!  That would be a very good thing.

Show 5 quoted lines

> dump_marks_helper() has a bug when dumping marks larger than 2^20-1,
> i.e., when the sparse array has more than two levels.  The bug was
> that the 'base' counter was being shifted by 20 bits at level 3, and
> then again by 10 bits at level 2, rather than a total shift of 20 bits
> in this argument to the recursive call:

I haven’t read or grokked that code you are changing, so I can’t comment on the substance of your patch. In case no one with such knowledge turns up, could you give a quick summary of what the existing code does and why?

Barring that, v1.5.0-rc4~14^2~61 (Added option to export the marks table when fast-import terminates., 2006-08-25) might be a good starting point for a person looking to understand.