git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Why is "git tag --contains" so slow?

From
Jakub Narebski <jnareb@gmail.com>
Date
Jul 8, 2010, 21:20 UTC
Message-ID
<201007082320.05017.jnareb@gmail.com>
In-Reply-To
<alpine.LFD.2.00.1007081559300.6020@xanadu.home>
Dnia czwartek 8. lipca 2010 22:13, Nicolas Pitre napisał:
> On Thu, 8 Jul 2010, Avery Pennarun wrote:
> > On Thu, Jul 8, 2010 at 3:29 PM, Nicolas Pitre <nico@fluxnic.net> wrote:
Show 21 quoted lines
> > > I might be looking at this from my own perspective as one of the few
> > > people who hacked extensively on the Git pack format from the very
> > > beginning.  But I do see a way for the pack format to encode commit and
> > > tree objects so that walking them would be a simple lookup in the pack
> > > index file where both the SHA1 and offset in the pack for each parent
> > > can be immediately retrieved.  Same for tree references.  No deflating
> > > required, no binary search, just simple dereferences.  And the pack size
> > > would even shrink as a side effect.
> > 
> > One trick that bup uses is an additional file that sits alongside the
> > pack and acts as an index.  In bup's case, this is to work around
> > deficiencies in the .idx file format when using ridiculously huge
> > numbers of objects (hundreds of millions) across a large number of
> > packfiles.  But the same concept could apply here: instead of doing
> > something like rev-cache, you could just construct the "efficient"
> > part of the packv4 format (which I gather is entirely related to
> > commit messages), and store it alongside each pack.
> 
> No.  I want the essential information in an efficient encoding _inside_ 
> the pack, actually replacing the existing encoding.  One of the goal is 
> also to reduce repository size, not to grow it.
That's a good idea.
 
Show 18 quoted lines
> > This would allow people to incrementally modify git to use the new,
> > efficient commit object storage, without breaking backward
> > compatibility with earlier versions of git.  (Just as bup can index
> > huge numbers of packed objects but still stores them in the plain git
> > pack format.)
> 
> Initially, what I'm aiming for is for pack-objects to produce the new 
> format, for index-pack to grok it, and for sha1_file:unpack_entry() to 
> simply regenerate the canonical object format whenever a pack v4 object 
> is encountered.  Also pack-objects would be able to revert the object 
> encoding to the current format on the fly when it is serving a fetch 
> request to a client which is not pack v4 aware, just like we do now with 
> the ofs-delta capability.
> 
> Once that stage is reached, I'll submit the lot and hope that other 
> people will help incrementally converting part of Git to benefit from 
> native access to the pack v4 data.  The tree object walk code would be 
> the first obvious candidate.  And so on.

If I remember correctly with pack v4 some operations like getting size of tree object needs encoding to current format, so they are slower than they should be (and perhaps a bit slower than current implementation). But that should be I think rare (well, unless one streams to 'git cat-file --batch / --batch-check').

Would pack v4 need index v4?

By the way, rev-cache project was started mainly to make "counting objects" part of clone / fetch faster. Would pack v4 offer the same without rev-cache?

-- 
Jakub Narebski
Poland
Previous: Nicolas PitreNext: Sverre Rabbelier
Message 39 of 46 in “Why is "git tag --contains" so slow?”
  1. Theodore Ts'oJul 1, 2010
  2. Shawn O. PearceJul 1, 2010
  3. Sam VilainJul 3, 2010
  4. Avery PennarunJul 1, 2010
  5. tytso@mit.eduJul 1, 2010
  6. Jeff KingJul 1, 2010
  7. Jeff KingJul 1, 2010
  8. tytso@mit.eduJul 2, 2010
  9. Jeff KingJul 3, 2010
  10. tytso@mit.eduJul 4, 2010
  11. Jeff KingJul 5, 2010
  12. 1/4 tag: speed up --contains calculationJeff King, Jul 5, 2010
  13. Jonathan NiederOct 13, 2010
  14. Clemens BuchacherOct 13, 2010
  15. Ævar Arnfjörð BjarmasonFeb 23, 2011
  16. Jeff KingFeb 23, 2011
  17. 2/4 limit "contains" traversals based on commit timestampJeff King, Jul 5, 2010
  18. Jonathan NiederOct 13, 2010
  19. 3/4 default core.clockskew variable to one dayJeff King, Jul 5, 2010
  20. 4/4 name-rev: respect core.clockskewJeff King, Jul 5, 2010
  21. Jeff KingJul 5, 2010
  22. Jonathan NiederOct 14, 2010
  23. Clemens BuchacherOct 16, 2010
  24. Jeff KingOct 27, 2010
  25. Clemens BuchacherOct 28, 2010
  26. tytso@mit.eduJul 5, 2010
  27. Jeff KingJul 6, 2010
  28. Will PalmerJul 6, 2010
  29. tytso@mit.eduJul 6, 2010
  30. Jeff KingJul 8, 2010
  31. Will PalmerJul 8, 2010
  32. tytso@mit.eduJul 8, 2010
  33. Jeff KingJul 7, 2010
  34. Theodore TsoJul 8, 2010
  35. Jakub NarebskiJul 8, 2010
  36. Nicolas PitreJul 8, 2010
  37. Avery PennarunJul 8, 2010
  38. Nicolas PitreJul 8, 2010
  39. Jakub NarebskiJul 8, 2010
  40. Sverre RabbelierJul 8, 2010
  41. Nicolas PitreJul 8, 2010
  42. Nicolas PitreJul 8, 2010
  43. Jeff KingJul 8, 2010
  44. Johan HerlandJul 8, 2010
  45. Nicolas PitreJul 8, 2010
  46. Jeff KingJul 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.