Re: [PATCHv2/RFC] gitweb: Prepare for splitting gitweb

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 8, 2010, 06:59 UTC
Message-ID: <201007080859.33958.jnareb@gmail.com>
In-Reply-To: <7v39vustku.fsf@alter.siamese.dyndns.org>

Dnia czwartek 8. lipca 2010 02:30, Junio C Hamano napisał:

Show 30 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> >> > +install-modules:
> >> > +	install_dirs=$(sort $(dir $(GITWEB_MODULES))) && \
> >> > ...
> >
> > For example with the following Makefile:
> >
> >   GITWEB_MODULES += GitwebCache/SimpleFileCache.pm
> >   GITWEB_MODULES += GitwebCache/Capture.pm
> >   GITWEB_MODULES += GitwebCache/Capture/SelectFH.pm
> >   GITWEB_MODULES += Gitweb/Config.pm
> >   
> >   all:
> >   	@echo $(sort $(dir $(GITWEB_MODULES)))
> >
> > running 'make' results in:
> >
> >   Gitweb/ GitwebCache/ GitwebCache/Capture/
> 
> 
> Try replacing that with:
> 
> 	all:
>         	install_dirs=$(sort $(dir $(GITWEB_MODULES))) && \
>                 echo $$install_dirs
> 
> perhaps?
> 
> Hint: dq.

You are completely right. I'm sorry. I should have copied the structure from "[PATCH 2/2 v2] Makefile: work around ksh's failure to handle missing list argument to for loop" more carefully.

I'll resend it.

-- 
Jakub Narebski
Poland