git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/13] Add skeleton SVN client and Makefile

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jul 7, 2010, 19:30 UTC
Message-ID
<20100707193017.GA2911@burratino>
In-Reply-To
<20100707170926.GC18806@debian>
Ramkumar Ramachandra wrote:
> Here's a diff of the modifications I made after your review:
That’s quite helpful.
> +++ b/svndumpr.c
> @@ -76,31 +76,19 @@ static svn_error_t *replay_revend(svn_revnum_t revision,
[...]
Show 8 quoted lines
> +	/* Populte ctx->auth_baton with the auth baton
> +	   non-interactively. Arguments 3, 4 and 5 are for username,
> +	   password and config_dir which is NULL in this case. Set
> +	   no_auth_cache and trust_serv_cert to FALSE, don't provide a
> +	   config, and omit cancel_func/ cancel_baton */
>  	SVN_ERR(svn_cmdline_create_auth_baton(&(ctx->auth_baton), TRUE,
>  					      NULL, NULL, NULL, FALSE,
>  					      FALSE, NULL, NULL, NULL,

I think you took my suggestion too seriously here. Such a comment probably will not help people much; instead, maybe a more focused comment can help the curious avoid looking up svn_cmdline_create_auth_baton:

	/* Default authentication providers for noninteractive
	   use. */
	SVN_ERR(svn_cmdline_create_auth_baton(...

Looking this up, I notice that function was added in svn 1.6. Hopefully that is okay, since this code is destined for svn trunk.

Except as noted above,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 6 of 31 in “[GSoC update] git-remote-svn: Week 10”
  1. Ramkumar RamachandraJul 7, 2010
  2. 01/13 Add LICENSERamkumar Ramachandra, Jul 7, 2010
  3. 02/13 Add skeleton SVN client and MakefileRamkumar Ramachandra, Jul 7, 2010
  4. Jonathan NiederJul 7, 2010
  5. Ramkumar RamachandraJul 7, 2010
  6. Jonathan NiederJul 7, 2010
  7. Ramkumar RamachandraJul 7, 2010
  8. Daniel ShahafJul 7, 2010
  9. 03/13 Add debug editor from Subversion trunkRamkumar Ramachandra, Jul 7, 2010
  10. Jonathan NiederJul 7, 2010
  11. 04/13 Add skeleton dump editorRamkumar Ramachandra, Jul 7, 2010
  12. Jonathan NiederJul 7, 2010
  13. Ramkumar RamachandraJul 8, 2010
  14. 05/13 Drive the debug editorRamkumar Ramachandra, Jul 7, 2010
  15. Jonathan NiederJul 7, 2010
  16. Ramkumar RamachandraJul 7, 2010
  17. Jonathan NiederJul 7, 2010
  18. Ramkumar RamachandraJul 8, 2010
  19. 06/13 Dump the revprops at the start of every revisionRamkumar Ramachandra, Jul 7, 2010
  20. Jonathan NiederJul 7, 2010
  21. Ramkumar RamachandraJul 21, 2010
  22. Julian FoadJul 26, 2010
  23. Ramkumar RamachandraJul 26, 2010
  24. 07/13 Implement open_root and close_editRamkumar Ramachandra, Jul 7, 2010
  25. 08/13 Implement dump_nodeRamkumar Ramachandra, Jul 7, 2010
  26. 09/13 Implement directory-related functionsRamkumar Ramachandra, Jul 7, 2010
  27. 10/13 Implement file-related functionsRamkumar Ramachandra, Jul 7, 2010
  28. 11/13 Implement apply_textdeltaRamkumar Ramachandra, Jul 7, 2010
  29. 12/13 Implement close_fileRamkumar Ramachandra, Jul 7, 2010
  30. 13/13 Add a validation scriptRamkumar Ramachandra, Jul 7, 2010
  31. Ramkumar RamachandraJul 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.