Re: Re: [PATCH v2 3/4] extent setup_revisions() so it works with submodules

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Jul 7, 2010, 13:37 UTC
Message-ID: <20100707133723.GB35678@book.hvoigt.net>
In-Reply-To: <7veiff274b.fsf@alter.siamese.dyndns.org>

Hi,

On Tue, Jul 06, 2010 at 10:28:20PM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> Heiko Voigt <hvoigt@hvoigt.net> writes:
> 
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> 
> This needs a bit more explanation.  "Exten_d_ setup_revisions()" is fine,
> but "works with submodules"???  How? and what do the caller need to do?
> 
> Something like...
> 
>     Subject: setup_revisions(): allow walking history in a submodule
> 
>     By passing the path to a submodule in opt->submodule, the function can
>     be used to walk history in the named submodule repository, instead of
>     the toplevel repository.

Will take that. Thanks.

cheers Heiko