Re: [PATCH] string_list: Add STRING_LIST_INIT macro and make use of it.
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jul 2, 2010, 19:30 UTC
- Message-ID
- <20100702193002.GB6585@burratino>
- In-Reply-To
- <bcb1b64b5db55dd11a398da3cf2c95145852ddfb.1278097858.git.tfransosi@gmail.com>
Thiago Farina wrote:
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Um, I am not so fond of this one.
The argument to STRING_LIST_INIT is hard to interpret without familiarity. What did you think of Peter’s suggestion to use an a different macro for the strdup_strings case? Something like STRING_LIST_INIT_DUP_ON_APPEND, but perhaps shorter.
It would also be nice to update Documentation/technical/api-string-list.txt with whatever you choose.
That said, I do like the goal of making it easier to reorganize struct string_list later if needed.