Re: [WIP PATCH 1/7] Add skeleton RA svnclient

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 25, 2010, 14:45 UTC
Message-ID: <20100625144544.GA7710@burratino>
In-Reply-To: <AANLkTimirObq-HBrB4rQdAprN8mfd92rfFKSegJKwMsc@mail.gmail.com>

Hi Ram,

Ramkumar Ramachandra wrote:

> I also highly recommend reading the API documentation and
> going through the code for answers to "why is it like THIS" questions
> as I haven't manged to clean out the Subversion style yet.

If this code is ultimately destined for the svnsync tree (as it seems it is), it might be possible to save time by just sticking to the svn style. I think this would be a typical place where we relax the git style guidelines a bit.

On the other hand, during development, if you want to use some other style (or if you want to write in Smalltalk for that matter), that’s fine by me. I don’t want to dictate your development style. I am only mentioning style now because I suspect it would be easier to review code that follows a single convention (which could be Subversion’s, or Git’s, or some well defined hybrid, or something else entirely, or ...).

>> SVN_ERR does not print anything.  It may return(), though.

Ah, so it is an exception handling mechanism.

Show 5 quoted lines

> These svn_cmdline functions are actually shortcuts- they do all the
> initializations required for a "typical" command line SVN client. It
> saves me the trouble of having to figure out what I missed
> initializing: I'll be using more of them in future; to eliminate the
> auth baton creation by hand, for example.

Thanks again for the explanations.

Jonathan