Re: [PATCH v4] Do not decode url protocol.

From: Jeff King <peff@peff.net>
Date: Jun 23, 2010, 17:38 UTC
Message-ID: <20100623173859.GA16938@coredump.intra.peff.net>
In-Reply-To: <7v4ogtfylw.fsf@alter.siamese.dyndns.org>

On Wed, Jun 23, 2010 at 10:27:39AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> > When using the protocol git+ssh:// for example we do not want to
> > decode the '+' as a space. The url decoding must take place only
> > for the server name and parameters.
> >
> > This fixes a regression introduced in 9d2e942.
> 
> Sign-off?
> 
> As the patch was whitespace-broken, I'm proposing to rewrite it like the
> following.
> 
> -- >8 -- 
> url.c: "<scheme>://" part at the beginning should not be URL decoded

I think this is cleaner than Pascal's patch.

Acked-by: Jeff King <peff@peff.net>

Thanks all for fixing my bug. :)

-Peff