Re: [PATCH GSoC] gitweb: Add support for enabling 'write' feature

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 22, 2010, 19:23 UTC
Message-ID: <201006222123.54352.jnareb@gmail.com>
In-Reply-To: <AANLkTimpF6CMF0yDmaxABR0BYOBE75sR5Zwtsb79fU4t@mail.gmail.com>

Dnia wtorek 22. czerwca 2010 20:35, Pavan Kumar Sunkara napisał:

Show 10 quoted lines

> 2010/6/22 Jakub Narebski <jnareb@gmail.com>:
>> On Tue, 22 June 2010, Pavan Kumar Sunkara wrote:
>>
>>> Provide $feature{'write'} to enable the 'write'
>>> functionalities for gitweb. While outputting HTML
>>> it checks for gitweb_check_feature('write') and if
>>> it's enabled, proper links will appear along with
>>> the HTML divs.
>>>
>>> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>

Show 23 quoted lines

>>> --- a/gitweb/lib/Gitweb/Config.pm
>>> +++ b/gitweb/lib/Gitweb/Config.pm
>>> @@ -203,6 +203,17 @@ our %feature = (
>>>       # (an array) or gitweb_check_feature(<feature>) to check if <feature>
>>>       # is enabled
>>>
>>> +     # Enable the 'write' functionalities for gitweb. While outputting HTML
>>> +     # it checks for gitweb_check_feature('write') and if it's enabled,
>>> +     # proper links will appear along with the HTML divs.
>>> +
>>> +     # To enable system wide have in $GITWEB_CONFIG
>>> +     # $feature{'write'}{'default'} = [1];
>>> +     # Project specific override is not supported.
>>> +     'write' => {
>>> +             'override' => 0,
>>> +             'default' => [0]},
>>> +
>>>       # Enable the 'blame' blob view, showing the last commit that modified
>>>       # each line in the file. This can be very CPU-intensive.
>>
>> ...as there is nothing non-trivial in there.
> 
> But don't u think it would be like a small starting patch.

There is staring small, and there is too small.

You don't provide _any_ write functionality here, or even any authorization framework for write functionality, like checking if we are on localhost.

-- 
Jakub Narebski
Poland