git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] revert: accept arbitrary rev-list options

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 14, 2010, 05:29 UTC
Message-ID
<20100614052938.GB1737@burratino>
In-Reply-To
<20100614052027.GA1509@burratino>
From: Christian Couder <chriscool@tuxfamily.org>
This can be useful to do something like:
git rev-list --reverse master -- README | git cherry-pick -n --stdin
without using xargs.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 Documentation/git-cherry-pick.txt   |    7 +++++++
 builtin/revert.c                    |    3 ++-
 t/t3508-cherry-pick-many-commits.sh |   10 ++++++++++
 3 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/Documentation/git-cherry-pick.txt b/Documentation/git-cherry-pick.txt
index bcb4c75..f047739 100644
--- a/Documentation/git-cherry-pick.txt
+++ b/Documentation/git-cherry-pick.txt
@@ -113,6 +113,13 @@ git cherry-pick --ff ..next::
 	are in next but not HEAD to the current branch, creating a new
 	commit for each new change.
 
+git rev-list --reverse master -- README | git cherry-pick -n --stdin::
+
+	Apply the changes introduced by all commits on the master
+	branch that touched README to the working tree and index,
+	so the result can be inspected and made into a single new
+	commit if suitable.
+
 Author
 ------
 Written by Junio C Hamano <gitster@pobox.com>
diff --git a/builtin/revert.c b/builtin/revert.c
index 853e9e4..67e191b 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -78,7 +78,8 @@ static void parse_args(int argc, const char **argv)
 			die("program error");
 	}
 
-	commit_argc = parse_options(argc, argv, NULL, options, usage_str, 0);
+	commit_argc = parse_options(argc, argv, NULL, options, usage_str,
+	                            PARSE_OPT_KEEP_UNKNOWN);
 	if (commit_argc < 1)
 		usage_with_options(usage_str, options);
 
diff --git a/t/t3508-cherry-pick-many-commits.sh b/t/t3508-cherry-pick-many-commits.sh
index 26a8730..93d7189 100755
--- a/t/t3508-cherry-pick-many-commits.sh
+++ b/t/t3508-cherry-pick-many-commits.sh
@@ -92,4 +92,14 @@ test_expect_failure 'cherry-pick -3 fourth works' '
 	test "$(git rev-parse --verify HEAD)" != "$(git rev-parse --verify fourth)"
 '
 
+test_expect_success 'cherry-pick --stdin works' '
+	git checkout -f master &&
+	git reset --hard first &&
+	test_tick &&
+	git rev-list --reverse first..fourth | git cherry-pick --stdin &&
+	git diff --quiet other &&
+	git diff --quiet HEAD other &&
+	test "$(git rev-parse --verify HEAD)" != "$(git rev-parse --verify fourth)"
+'
+
 test_done
-- 
1.7.1.246.g398e5.dirty
Previous: Jonathan NiederNext: Jonathan Nieder
Message 4 of 7 in “revert: add --stdin option to read commits from stdin”
  1. revert: add --stdin option to read commits from stdinChristian Couder, Jun 14, 2010
  2. Jonathan NiederJun 14, 2010
  3. 1/3 t3508 (cherry-pick): futureproof against unmerged filesJonathan Nieder, Jun 14, 2010
  4. 2/3 revert: accept arbitrary rev-list optionsJonathan Nieder, Jun 14, 2010
  5. 3/3 revert: do not rebuild argv on heapJonathan Nieder, Jun 14, 2010
  6. Christian CouderJun 15, 2010
  7. Johannes SixtJun 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.