git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix typo in hash key name in %opts in git_header_html

From
Jakub Narebski <jnareb@gmail.com>
Date
Jun 12, 2010, 22:35 UTC
Message-ID
<20100612223425.19002.86147.stgit@localhost.localdomain>

The name of the key has to be the same in call site handle_errors_html and in called subroutine that uses it, i.e. git_header_html.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
I'm sorry about that.  Stupid mistake.

I have noticed this when working (again) on gitweb output caching series. There was toss-up on which version ''-no_http_headers' or '-no_http_header' to choose.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 934aacb..e108bbc 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3220,7 +3220,7 @@ sub git_header_html {
 	}
 	print $cgi->header(-type=>$content_type, -charset => 'utf-8',
 	                   -status=> $status, -expires => $expires)
-		unless ($opts{'-no_http_headers'});
+		unless ($opts{'-no_http_header'});
 	my $mod_perl_version = $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : '';
 	print <<EOF;
 <?xml version="1.0" encoding="utf-8"?>
Message 1 of 1 in “gitweb: Fix typo in hash key name in %opts in git_header_html”
  1. gitweb: Fix typo in hash key name in %opts in git_header_htmlJakub Narebski, Jun 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.