Did get this patch overlooked?
Am Dienstag 01 Juni 2010, 20:08:50 schrieb Alexander Stein:
Show 51 quoted lines
> This patch removes the prompting variable so git send-email always asks
> for a in-reply message ID (unless specified on command line) even when
> sendemail.from and sendemail.to is set in ~/.gitconfig or .git/config
>
> Signed-off-by: Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
> ---
> git-send-email.perl | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 111c981..4487472 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -136,7 +136,7 @@ my $auth;
> sub unique_email_list(@);
> sub cleanup_compose_files();
>
> -# Variables we fill in automatically, or via prompting:
> +# Variables we fill in automatically:
> my (@to,$no_to,@cc,$no_cc,@initial_cc,@bcclist,$no_bcc,@xh,
> $initial_reply_to,$initial_subject,@files,
> $author,$sender,$smtp_authpass,$annotate,$compose,$time);
> @@ -669,19 +669,16 @@ sub ask {
> return undef;
> }
>
> -my $prompting = 0;
> if (!defined $sender) {
> $sender = $repoauthor || $repocommitter || '';
> $sender = ask("Who should the emails appear to be from? [$sender] ",
> default => $sender);
> print "Emails will be sent from: ", $sender, "\n";
> - $prompting++;
> }
>
> if (!@to) {
> my $to = ask("Who should the emails be sent to? ");
> push @to, parse_address_line($to) if defined $to; # sanitized/validated
> later - $prompting++;
> }
>
> sub expand_aliases {
> @@ -703,7 +700,7 @@ sub expand_one_alias {
> @initial_cc = expand_aliases(@initial_cc);
> @bcclist = expand_aliases(@bcclist);
>
> -if ($thread && !defined $initial_reply_to && $prompting) {
> +if ($thread && !defined $initial_reply_to) {
> $initial_reply_to = ask(
> "Message-ID to be used as In-Reply-To for the first email? ");
> }