git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] commit.c - provide commit-type to the hooks/pre-commit script

From
Jeff King <peff@peff.net>
Date
Jun 6, 2010, 22:10 UTC
Message-ID
<20100606221037.GE6993@coredump.intra.peff.net>
In-Reply-To
<1275759590-16342-1-git-send-email-mlevedahl@gmail.com>
On Sat, Jun 05, 2010 at 01:39:50PM -0400, Mark Levedahl wrote:
Show 10 quoted lines
> -	if (!no_verify && run_hook(index_file, "pre-commit", NULL))
> +	if (!no_verify && run_hook(index_file, "pre-commit", amend ? "amend" : "normal", NULL))
> [...]
> -	against=HEAD
> +	if test "$1" = "amend"
> +	then
> +		against=HEAD~1
> +	else
> +		against=HEAD
> +	fi

Is there a reason to use the magic "amend" and "normal" words, if scripts are just going to end up changing them back into HEAD~1 and HEAD anyway?

-Peff
Previous: Mark LevedahlNext: Mark Levedahl
Message 3 of 7 in “commit.c - provide commit-type to the hooks/pre-commit script”
  1. 1/2 commit.c - provide commit-type to the hooks/pre-commit scriptMark Levedahl, Jun 5, 2010
  2. 2/2 git-gui - provide commit-type to the hooks/pre-commit scriptMark Levedahl, Jun 5, 2010
  3. Jeff KingJun 6, 2010
  4. Mark LevedahlJun 7, 2010
  5. Johannes SixtJun 7, 2010
  6. Jeff KingJun 7, 2010
  7. Mark LevedahlJun 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.