Re: (Mosty harmless) protocol error when pushing

From: Jeff King <peff@peff.net>
Date: May 27, 2010, 15:12 UTC
Message-ID: <20100527151222.GA18590@coredump.intra.peff.net>
In-Reply-To: <20100527113305.GB7865@LK-Perkele-V2.elisa-laajakaista.fi>

On Thu, May 27, 2010 at 02:33:05PM +0300, Ilari Liusvaara wrote:

Show 5 quoted lines

> I can't reproduce it either.
> 
> I tried testing using git:// over TLS. I could trigger the auto-gc,
> but got no messages about it (hmm... other sideband messages do
> work...) and no protocol error.

Same here. But look at Björn's original error, which contained:

  fatal: protocol error: bad line length character: Remo

So I think it may not just be an auto-gc, but an auto-gc which provokes prune-packed to say:

  Removing duplicate objects: 100% (256/256), done.

which happens only when it takes more than 2 seconds to remove all of the objects. But I was still not able to reproduce it, even after removing the delay:

diff --git a/builtin/prune-packed.c b/builtin/prune-packed.c
index f9463de..da1ab20 100644
--- a/builtin/prune-packed.c
+++ b/builtin/prune-packed.c
@@ -48,7 +48,7 @@ void prune_packed_objects(int opts)
 
 	if (opts == VERBOSE)
 		progress = start_progress_delay("Removing duplicate objects",
-			256, 95, 2);
+			256, 95, 0);
 
 	if (len > PATH_MAX - 42)
 		die("impossible object directory");

I notice that the original problem was seen when pushing to github. I
wonder if they are running an older version, or even a custom version
that behaves differently (perhaps with stdout and stderr file
descriptors set up differently for the gc or something like that).

-Peff