Re: [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure

From: Jakub Narebski <jnareb@gmail.com>
Date: May 23, 2010, 09:54 UTC
Message-ID: <201005231155.00819.jnareb@gmail.com>
In-Reply-To: <1274599968-3749-1-git-send-email-pavan.sss1991@gmail.com>

On Sun, 23 May 2010, Pavan Kumar Sunkara wrote:

Show 15 quoted lines

> git-instaweb in its current form (re)creates gitweb.cgi and
> (some of) required static files in $GIT_DIR/gitweb/ directory.
> Splitting gitweb would make it difficult for git-instaweb to
> continue with this method.
> 
> Use the instaweb.gitwebdir config variable to point git-instaweb script
> to a global directory which contains gitweb files as server root
> and the httpd.conf along with server logs and pid go into
> '$(GIT_DIR)/gitweb' directory.
> 
> While at it, change apache2 configuration to use the same access log
> and error log files as the rest of web servers supported by
> git-instaweb.
> 
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>

For what it is worth:

Acked-by: Jakub Narebski <jnareb@gmail.com>

But I think more important would be ACK from Eric Wong, author and maintainer of git-instaweb. I guess that because it is preparatory work, only related to the main stated goal of your GSoC 2010, you don't need "signoff" from mentor(s) (in the form of Mentored-by:)...

-- 
Jakub Narebski
Poland