Re: [PATCH RFC] Add a config verbose option fetch and push

From: Thomas Rast <trast@student.ethz.ch>
Date: May 22, 2010, 10:44 UTC
Message-ID: <201005221244.32213.trast@student.ethz.ch>
In-Reply-To: <AANLkTil-PDpdkcJaJn2FUrJrSIJ6lP0OcvY5l7HRorsa@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> Since Peter Kjellerstedt wanted --ff-only, and you want --verbose. I
> wonder whether a better solution wouldn't be to farm this
> functionality out to the config parser.

[...]

>     [fetch "option"]
>         verbose = 1
> 
> Is there any reason not to add such a general facility?

That would completely ruin the scriptability of almost all commands. Imagine the user added the following options as default:

  add --edit
  checkout --patch
  cherry-pick --no-commit
  commit --amend
  pull --rebase

I'm sure you can find one option that changes the command in something completely different *for every command*.

In fact even pull --ff-only has the same problem since it will refuse the merge in cases where an unmodified pull would go through.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch