Re: [PATCH GSoC] gitweb: Add global installation target for gitweb
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- May 15, 2010, 18:43 UTC
- Message-ID
- <201005152043.05698.jnareb@gmail.com>
- In-Reply-To
- <AANLkTilxlnUdfGEvpsaIKm3waSTGH_jUG9pW8ozc1PUJ@mail.gmail.com>
On Sat, 15 May 2010, Pavan Kumar Sunkara wrote:
Show 6 quoted lines
> So, what I need to do in this patch is add default values. Not > installing in 'install' target. ?? > Or any thing else. > > If you could specify what needs to be done, I will be happy resend > the patch.
To get my ACK for this patch it is enough to *not* add installing gitweb to 'install' target in main Makefile. IMVHO it should be left for next patch in this series.
P.S. By the way, you should write in comments to patch, i.e. between "---" separator and the diffstat, that this patch is based on 'next' branch, or perhaps even that it is based on commit 152d943 in 'jn/gitweb-install'.
>From Documentation/SubmittingChanges:
If you are preparing a work based on "next" branch, that is fine,
but please mark it as such.
^^^^^^^^^^^^^^^Keep up good work!
-- Jakub Narebski Poland