Re: Re: git log -M -- filename is not working?

From: Jeff King <peff@peff.net>
Date: May 12, 2010, 13:03 UTC
Message-ID: <20100512130339.GA19072@coredump.intra.peff.net>
In-Reply-To: <20100512124948.GA11761@coredump.intra.peff.net>

On Wed, May 12, 2010 at 08:49:48AM -0400, Jeff King wrote:

> Anyway, here is the patch. My testing so far has been very simple, so
> please try it on a few repos and let me know if it does what you expect
> in all cases. Note that is based on "next", as it has Bo's
> find_copies_harder patch.

By the way, here are some basic speed tests in git.git:

  $ time git log builtin >/dev/null
  real    0m0.486s
  user    0m0.468s
  sys     0m0.016s

  $ time git log --follow builtin >/dev/null
  real    0m23.518s
  user    0m23.469s
  sys     0m0.040s

So it's _way_ slower, but still snappy enough with the first few commits not to be awful. However, I haven't done any profiling, so it may be that we can improve that by limiting the rename-detection diff only to interesting paths.

-Peff