Re: [PATCH 4/8] Documentation/notes: simplify treatment of default notes ref

From: Thomas Rast <trast@student.ethz.ch>
Date: May 12, 2010, 07:46 UTC
Message-ID: <201005120946.31193.trast@student.ethz.ch>
In-Reply-To: <20100509032358.GD7958@progeny.tock>

Jonathan Nieder wrote:

Show 15 quoted lines

> @@ -187,13 +190,10 @@ CONFIGURATION
>  -------------
>  
>  core.notesRef::
> -	When showing commit messages, also show notes which are stored in
> -	the given ref.  The ref must be fully qualified.  If the given
> -	ref does not exist, it is not an error but means that no
> -	notes should be printed.
> -+
> -This setting defaults to "refs/notes/commits", and it can be overridden by
> -the 'GIT_NOTES_REF' environment variable.  See linkgit:git-notes[1].
> +	Notes ref to read and manipulate instead of
> +	`refs/notes/commits`.  Must be an unabbreviated ref name.
> +	This setting can be overridden through the environment and
> +	command line.

In the end result, this makes core.notesRef the only configuration variable which does not have its environment sibling named explicitly in the config section. Would you mind putting GIT_NOTES_REF back in the sentence for consistency with the other variables?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch