Re: [WIP PATCH] Add skeleton remote helper for SVN

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 10, 2010, 12:59 UTC
Message-ID: <20100510125953.GA5642@progeny.tock>
In-Reply-To: <AANLkTikFl25Hay7UEvsz5bsdg8fdT8485SxqgAZXCYqd@mail.gmail.com>

Hi Ram,

Ramkumar Ramachandra wrote:

> It'll be good if Jonathan's patch makes it to `master` by
> then, but I don't think I should prematurely rebase on patches that
> aren't in `master` yet.

Since the conflict resolution is trivial, I agree. When there is an actual dependency between patches, I think there is nothing wrong with basing one patch on another; as long as you make it clear what your patch applies to, humans and Junio’s scripts can cope with the task of applying one series on top of the topic branch for another.

Re your skeleton code, it looks reasonable to me. I could nitpick the names of the import_handler() and export_handler() functions and the needless use of do ... while, but I will refrain. :)

Much more importantly, there is something to play with now. On that note, is David’s code out there somewhere for people to fool around with? At this point, I am not interested in a stable interface or permanent history, just a way to try out the code and start to get used to it.

Thanks, Jonathan

[1] git://repo.or.cz/svn-all-fast-export.git