git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix a false negative in t5512 when run using sh -x

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 10, 2010, 11:31 UTC
Message-ID
<20100510113113.GA5162@progeny.tock>
In-Reply-To
<4BE7E7FD.7080607@viscovery.net>
Johannes Sixt wrote:
> I can just amend my patch, no problem, and we solve the issue as you
> propose (or perhaps not - it *is* ugly as hell).

For your application, I’d suggest using BASH_XTRACEFD. Or not, since it is good to reveal problems people will run into when they try sh -x some-particular-test.sh

Since the problem cases seem to be rare, I guess the ‘grep’ trick is good enough. It is nice anyway to be able to switch between fatal: and error: without breaking tests.

t9108 seems to have the same problem.  Maybe you skip svn tests?
Jonathan
Previous: Johannes SixtNext: Johannes Sixt
Message 8 of 9 in “Fix a false negative in t5512 when run using sh -x”
  1. Fix a false negative in t5512 when run using sh -xJohannes Sixt, May 10, 2010
  2. Tay Ray ChuanMay 10, 2010
  3. Sverre RabbelierMay 10, 2010
  4. Johannes SixtMay 10, 2010
  5. Sverre RabbelierMay 10, 2010
  6. Jonathan NiederMay 10, 2010
  7. Johannes SixtMay 10, 2010
  8. Jonathan NiederMay 10, 2010
  9. Johannes SixtMay 10, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.