Re: [PATCH] blame: add a range option to -L

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 2, 2010, 09:14 UTC
Message-ID: <20100502091433.GA1854@progeny.tock>
In-Reply-To: <1272662989-563-1-git-send-email-wfp5p@virginia.edu>

Bill Pemberton wrote:

> In addition to + and - you can now use r to specify how many lines
> around <start> that you want to see.  For example: -L 20,r5 would show
> lines 15 through 25

From too much exposure to subversion, the r suggests “revision”. But ± is too hard to type, so I guess r will have to do.

Show 6 quoted lines

> +++ b/Documentation/blame-options.txt
> @@ -32,6 +32,12 @@ This is only valid for <end> and will specify a number
>  of lines before or after the line given by <start>.
>  +
>  
> +- rrange

Maybe -rradius?  “range” sounds like an interval with specified endpoints.

Show 9 quoted lines

> +		/* if top is negative then top is actually a range
> +		   that was specified with the r option */
> +		if (*top < 1) {
> +		    long x = *top;
> +		    *top = *bottom - x;
> +		    *bottom += x;
> +		    if (*bottom < 1)
> +			*bottom = 1;
> +		}

How does this treat -L 5,-10?

Jonathan